Add web3/metamask-compatible personal_sign and personal_recover, fixes #18 #30
Conversation
buhrmi
changed the title
|
This should resolve #18 |
|
Awesome! Thank you for spearheading this. One thing: I've been trying to move towards accepting and returning binary data in hex. Could you switch the API to match that? |
|
done |
|
what's the holdup? |
|
This is a side project, so it's a bit hard to find the time to give this the thought it needs. Anyway, thanks for the contribution and for your patience. Just bumped the version and released the newest gem. 🍻 |
|
awesome. yeah I totally get it. It's an amazing gem for a side project. anyways, now the method signature is not in line with the rest of the API (expecting hex parameters whereas the rest of the API is still expecting binary). ah well. good enough :P |
|
Thanks, happy it's getting some usage! I'm only really moving towards hex strings. Added the tx_data_hex configuration option a few minor versions back. I'd like to get all parts of the gem using it for consistency's sake, but like I said, tight on time. |
No description provided.